[rules score] rework dot integration#288
Closed
hoe-jo wants to merge 1 commit into
Closed
Conversation
hoe-jo
commented
Jun 22, 2026
hoe-jo
commented
Contributor
- remove graphviz directive support
- change lobster report to plantuml directive
- use dot for rendering in plantuml (smetana as fallback)
hoe-jo
requested review from
LittleHuba,
castler,
limdor and
ramceb
as code owners
- remove graphviz directive support - change lobster report to plantuml directive - use dot for rendering in plantuml (smetana as fallback)
hoe-jo
force-pushed
the
joho_rework_dot_integration
branch
from
a02b34c to
9291581
Compare
LittleHuba
reviewed
Jun 22, 2026
Comment on lines
+207
to
+217
| _dot_path = Path(_resolve_execroot_path(os.environ["GRAPHVIZ_DOT"])) | ||
| # Derive library search paths from the binary location so the rule passes | ||
| # only GRAPHVIZ_DOT and conf.py stays self-contained. | ||
| # The graphviz cmake deb installs: | ||
| # usr/bin/dot_builtins ← GRAPHVIZ_DOT points here | ||
| # usr/lib/*.so* ← LD_LIBRARY_PATH (core shared libs) | ||
| # usr/lib/graphviz/*.so* ← LTDL_LIBRARY_PATH (layout/render plugins) | ||
| _usr_dir = _dot_path.parent.parent # usr/bin → parent → usr | ||
| os.environ["LD_LIBRARY_PATH"] = str(_usr_dir / "lib") | ||
| os.environ["LTDL_LIBRARY_PATH"] = str(_usr_dir / "lib" / "graphviz") | ||
| plantuml = f"{plantuml_path} -graphvizdot {_dot_path}" |
Contributor
There was a problem hiding this comment.
This is really nasty...
Better go into this direction:
eclipse-score/communication#548
Contributor
Author
|
is addresses in this PR #293 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.